Skip to content

fix: return psbt spend utxo errors#1035

Open
reez wants to merge 1 commit into
bitcoindevkit:masterfrom
reez:spend-utxo
Open

fix: return psbt spend utxo errors#1035
reez wants to merge 1 commit into
bitcoindevkit:masterfrom
reez:spend-utxo

Conversation

@reez

@reez reez commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Description

I think it would be good for Psbt::spend_utxo to return typed PsbtErrors instead of potentially panicking when rust-bitcoin reports missing or outofbounds spend UTXOs.

Notes to the reviewers

Documentation

Changelog

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added exactly one changelog:* label
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@ItoroD ItoroD left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 23bb9a9

Learning a lot from these error handling PRs.

@thunderbiscuit thunderbiscuit added this to the 4.0.0 milestone Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants